Add Prometheus-readable metrics endpoint #194
Conversation
There was a problem hiding this comment.
I don't read Haskell very well so I can't comment too much, but I have one suggestion
Right now we have a single counter for the number of PRs merged. This is not that helpful if you have many projects in a single instance like we do. Perhaps we could add a project label to the counter and track the metric by project?
Sorry for the lack of clarity, that's what it already does! |
There was a problem hiding this comment.
Thanks for the PR! This is going to give some wonderful insights!
Some comments, and a general note:
Could you test this PR and make sure:
- The counter is indeed increased when a PR is merged
- The /metrics endpoint gives a good output (you could post it in this PR)
|
@OpsBotPrime merge |
|
Pull request approved for merge by @DiegoDiverio, rebasing now. |
Approved-by: DiegoDiverio Auto-deploy: false
|
Rebased as 7e9026c, waiting for CI … |
|
CI job 🟡 started. |
Fixes part of #99 by showing Prometheus-readable metrics on a configurable port, only showing one metric (number of PRs merged) at the moment. Other metrics will be easier to add now, but they should be described in new issues, in more specific detail, when the need arises.